The patch below addresses a buffer overflow related to "nethack -s". *** nethack-3.4.0/src/topten.c.orig Mon Feb 4 08:06:07 2002 --- nethack-3.4.0/src/topten.c Mon Feb 10 10:48:55 2003 *************** *** 856,861 **** --- 856,867 ---- else { if (playerct > 1) Strcat(pbuf, "any of "); for (i = 0; i < playerct; i++) { + /* stop printing players if there are too many to fit */ + if (strlen(pbuf) + strlen(players[i]) + 2 >= BUFSZ) { + if (strlen(pbuf) < BUFSZ-4) Strcat(pbuf, "..."); + else Strcpy(pbuf+strlen(pbuf)-4, "..."); + break; + } Strcat(pbuf, players[i]); if (i < playerct-1) { if (players[i][0] == '-' &&